Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum CodeQL bundle version to 2.6.3 #1358

Merged
merged 11 commits into from
Nov 16, 2022

Conversation

henrymercer
Copy link
Contributor

Now that GHES 3.2 is deprecated, we can clean up a bunch of tech debt in the Action by bumping our minimum CodeQL Bundle version to 2.6.3, the first version that went into GHES 3.3.

The highlight here is that the Action no longer needs to count lines of code itself, since now all supported versions of the CLI can do that. This allows us to remove a bunch of code and 14 dependencies!

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@adityasharad
Copy link
Contributor

Our docs for direct CodeQL CLI use recommend CodeQL 2.6.3 even for GHES 3.1 and 3.2, so this bump is acceptable even if we have a few customers gradually upgrading from deprecated GHES versions.

@henrymercer henrymercer marked this pull request as ready for review November 11, 2022 19:32
@henrymercer henrymercer requested a review from a team as a code owner November 11, 2022 19:32
@henrymercer
Copy link
Contributor Author

All checks have passed. The PR isn't green yet since it updates the checks to use newer bundle versions.

aeisenberg
aeisenberg previously approved these changes Nov 14, 2022
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good. Nice to get rid of some code. Looks like there are some merge conflicts now, though.

@henrymercer
Copy link
Contributor Author

Resolved conflicts by rerunning the workflow generator and rebuilding the Action.

aeisenberg
aeisenberg previously approved these changes Nov 14, 2022
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#dead-code-society

@henrymercer henrymercer changed the base branch from main to henrymercer/delete-runner-part-2 November 15, 2022 20:58
Base automatically changed from henrymercer/delete-runner-part-2 to main November 15, 2022 21:19
@henrymercer henrymercer merged commit 1935d19 into main Nov 16, 2022
@henrymercer henrymercer deleted the henrymercer/require-cli-2.6.3 branch November 16, 2022 10:38
@github-actions github-actions bot mentioned this pull request Nov 16, 2022
7 tasks
@github-actions github-actions bot mentioned this pull request Nov 16, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants