-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor handling of feature flags #1284
Merged
Merged
Commits on Oct 5, 2022
-
Refactor handling of feature flags
This commit centralizes how feature flags are handled. All feature flags must now add an entry in the `featureFlagConfig` dictionary. This dictionary associates the flag with an environment variable name and optionally a minimum version for CodeQL. The new logic is: - if the environment variable is set to false: disabled - if the minimum version requirement specified and met: disabled - if the environment variable is set to true: enable - Otherwise check feature flag enablement from the server
Configuration menu - View commit details
-
Copy full SHA for e5c3375 - Browse repository at this point
Copy the full SHA e5c3375View commit details
Commits on Oct 6, 2022
-
- Change env var name for `MlPoweredQueriesEnabled` - Throw error if minimumVersion is specified, but CodeQL argument is not supplied. - Fix failing tests. Note that I removed a config-utils test because it is no longer relevant since we handle codeql minimum versions in the `getValue` function.
Configuration menu - View commit details
-
Copy full SHA for b16314e - Browse repository at this point
Copy the full SHA b16314eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6de05e4 - Browse repository at this point
Copy the full SHA 6de05e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5915e70 - Browse repository at this point
Copy the full SHA 5915e70View commit details
Commits on Oct 7, 2022
-
Extract GitHubFeatureFlags to a separate class
Internal refactoring so that `GitHubFeatureFlags` is private only. The public facing class is `Features`.
Configuration menu - View commit details
-
Copy full SHA for b27aed7 - Browse repository at this point
Copy the full SHA b27aed7View commit details -
Avoid usage of "Feature Flag" unless we are talking specifically about the response from github features api. Otherwise, use terms like "Toggleable features". Note both "toggleable" and "togglable" appear to be valid spellings of the word. I chose the first for no good reason.
Configuration menu - View commit details
-
Copy full SHA for 1a17c59 - Browse repository at this point
Copy the full SHA 1a17c59View commit details -
Configuration menu - View commit details
-
Copy full SHA for 919e4ca - Browse repository at this point
Copy the full SHA 919e4caView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c869f8 - Browse repository at this point
Copy the full SHA 6c869f8View commit details
Commits on Oct 11, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 701cea3 - Browse repository at this point
Copy the full SHA 701cea3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 43c3ed9 - Browse repository at this point
Copy the full SHA 43c3ed9View commit details
Commits on Oct 12, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 34d48f8 - Browse repository at this point
Copy the full SHA 34d48f8View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.