Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autobuild Go in analyze if not already built #1219

Merged
merged 10 commits into from
Sep 2, 2022

Conversation

angelapwen
Copy link
Contributor

This change will run the autobuilder for Golang in the analyze step if:

  • the feature flag golang_extraction_reconciliation_enabled is on
  • the autobuild step has not already run for Go
  • the user has not provided manual build steps for Go

This change should be a no-op for now, as if a user has not provided manual build steps for Go, we treat Go as an interpreted language and the autobuilder will run even if users have not included the autobuild action.

With some imminent changes where we will not treat Go as an interpreted language, we introduce this change to maintain backwards compatibility for users who may have removed the autobuild step and who have not provided manual build steps. In this case, we will still autobuild for them at the beginning of the analyze step.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@angelapwen angelapwen requested a review from a team as a code owner August 26, 2022 22:38
@angelapwen angelapwen force-pushed the angelapwen/autobuild-in-analyze branch from 781cafc to 893add6 Compare August 26, 2022 22:43
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor things.

src/analyze-action.ts Outdated Show resolved Hide resolved
src/analyze-action.ts Outdated Show resolved Hide resolved
@henrymercer
Copy link
Contributor

I'll move this PR forward while Angela's on vacation. I'll start by addressing Andrew's review comments and adding a PR check to test the new behavior.

@henrymercer henrymercer marked this pull request as draft August 30, 2022 17:06
@henrymercer henrymercer force-pushed the angelapwen/autobuild-in-analyze branch from 3adbc27 to 962795a Compare August 31, 2022 11:57
@henrymercer henrymercer force-pushed the angelapwen/autobuild-in-analyze branch from e86336e to 8e0846c Compare August 31, 2022 12:22
@henrymercer henrymercer marked this pull request as ready for review August 31, 2022 14:29
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A minor comment.

src/analyze-action.ts Outdated Show resolved Hide resolved
@henrymercer henrymercer merged commit 21530f5 into main Sep 2, 2022
@henrymercer henrymercer deleted the angelapwen/autobuild-in-analyze branch September 2, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants