Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency on @actions/cache #1164

Merged
merged 1 commit into from
Aug 5, 2022
Merged

Conversation

edoardopirovano
Copy link
Contributor

This dependency isn't actually used yet, but will be needed for the TRAP caching feature that I am currently working on. I was originally planning to add it in the same PR where it gets used, but given how many changes to transitive dependencies this generates, I think it makes sense to do it before in a separate PR to make reviewing easier and also test this in isolation.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@edoardopirovano edoardopirovano requested a review from a team as a code owner August 3, 2022 12:42
@edoardopirovano edoardopirovano added the Update dependencies Trigger PR workflow to update dependencies label Aug 3, 2022
@github-actions github-actions bot removed the Update dependencies Trigger PR workflow to update dependencies label Aug 3, 2022
Copy link
Contributor

@criemen criemen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm not really sure how to review this PR, outside from the changes to package.json.

@edoardopirovano
Copy link
Contributor Author

LGTM, but I'm not really sure how to review this PR, outside from the changes to package.json.

I don't think there's much more to review than that. This CI check will make sure everything else matches what's declared there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants