Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md #1052

Merged
merged 2 commits into from
May 2, 2022
Merged

Update CONTRIBUTING.md #1052

merged 2 commits into from
May 2, 2022

Conversation

aeisenberg
Copy link
Contributor

Clarify instructions for updating required checks

Clarify instructions for updating required checks
@aeisenberg aeisenberg requested a review from a team as a code owner May 2, 2022 15:29
CONTRIBUTING.md Outdated
@@ -84,18 +84,19 @@ Since the `codeql-action` runs most of its testing through individual Actions wo

To regenerate the PR jobs for the action:

1. From a terminal, run the following commands (replace `SHA` with the sha of the commit whose checks you want to use, typically this should be the latest from `main`):
1. In a terminal check out the `SHA` whose checks you want to use as the base. Typically, this will be `main`.
2. From a terminal, run the following commands (replace `SHA` with the sha of the commit whose checks you want to use, typically this should be the latest from `main`):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove the "replace SHA" part of the step now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. I had that originally, but messed up my first attempt at the PR. Let me fix it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants