Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👀 status for hard to analyze instances #64

Open
kalexmills opened this issue Dec 23, 2020 · 1 comment
Open

👀 status for hard to analyze instances #64

kalexmills opened this issue Dec 23, 2020 · 1 comment
Labels
discussion Maintainers are inviting discussion. enhancement New feature or request vet-bot the issue is part of VetBot's responsibility

Comments

@kalexmills
Copy link
Contributor

kalexmills commented Dec 23, 2020

For some codebases, some of the goroutine searches seem to be really hairy (they're actually just a BFS tree being printed in an exceptionally lazy manner).

If we really want to see them analyzed, we're going to need to visualize them like trees. This means laying them out as trees either in a textual format (which VetBot could do) or using some other tool.

One strategy even if the output becomes easier to parse could be to add a new label for issues whose callgraphs may be much too complicated and need further analysis. We can sequester them and learn how to deal with them later.

With that in mind, I think adding a new 👀 status will allow us to set aside issues that are going to need additional data crunching in order to classify. The point here isn't to kick the can down the road, we might learn that there aren't enough issues that fall into this category to justify a significant development effort.

This is open for discussion.

@kalexmills kalexmills added the enhancement New feature or request label Dec 23, 2020
@kalexmills
Copy link
Contributor Author

This 👀 status could also be used to say "I checked... I couldn't find anything here one way or another."

It might be useful to mark false-positives.

@kalexmills kalexmills added the discussion Maintainers are inviting discussion. label Dec 23, 2020
@kalexmills kalexmills changed the title 👀 status for hard to analyze Goroutine Paths 👀 status for hard to analyze instances Dec 23, 2020
@kalexmills kalexmills added the vet-bot the issue is part of VetBot's responsibility label Dec 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Maintainers are inviting discussion. enhancement New feature or request vet-bot the issue is part of VetBot's responsibility
Projects
None yet
Development

No branches or pull requests

1 participant