Abolish restrictions governing colour choices #4978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 31, 2020
sambacha
pushed a commit
to freight-trust/linguist
that referenced
this pull request
Sep 4, 2020
This was referenced Apr 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first of three PRs to fix #4291 and #4506, both of which are blocked on this change. I won't repeat what those threads already do a good job of explaining.
Status of related tasks:
The problem
We're still enforcing colour-difference thresholds, but nobody can explain why. _"Still waiting on GitHub's designers" isn't a sound justification when they've had 1.5 years to raise an objection to the colour-test's removal.
The solution
Stop giving a crap and just go for it. Chances are the test appears 10 times more important to us than it does GitHub's designers, because they haven't been the ones dealing with it for the past 5 years.