.sql heuristic falls back to SQL #4888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been automatically marked as stale because it has not had recent activity, and will be closed if no further activity occurs. If this pull request was overlooked, forgotten, or should remain open for any other reason, please reply here to call attention to it and remove the stale status. Thank you for your contributions. |
smola
changed the title
smola
changed the title
|
This pull request has been automatically marked as stale because it has not had recent activity, and will be closed if no further activity occurs. If this pull request was overlooked, forgotten, or should remain open for any other reason, please reply here to call attention to it and remove the stale status. Thank you for your contributions. |
Alhadis
requested changes
Aug 30, 2020
- add SQL as fallback for .sql extension. - SQL PL: add SYSCAT.|SYSPROC.|ASSOCIATE RESULT SET|END\! - T-SQL: [dbo]
Alhadis
approved these changes
Aug 30, 2020
sambacha
pushed a commit
to freight-trust/linguist
that referenced
this pull request
Sep 4, 2020
* .sql falls back to SQL - add SQL as fallback for .sql extension. - SQL PL: add SYSCAT.|SYSPROC.|ASSOCIATE RESULT SET|END\! - T-SQL: [dbo] * improve sql heuristics
ioistired
added a commit
to EmoteBot/EmoteCollector
that referenced
this pull request
Dec 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is part of a series of PRs for SQL, see #4884.
Do not use the classifier strategy for
.sql, fallback to SQL. The premise here is that classifying any SQL variant as SQL is less wrong than classifying it as the wrong variant.Adds some new patterns to SQL PL and T-SQL to keep everything working, at least for current samples.
Checklist: