-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Nim's colour to better match the logo #4866
Conversation
Alternatives to try: |
About feedback - is it fine if people just do thumbs up/down to this PR? I've spread this PR in all places in the community I know about, and some well-known Nim developers (including Nim's creator :P) already upvoted this PR. Of course we still need to wait a few more days so more people can vote on this change. And now I need to find a good goldish-like colour for Nim, because these two seem to be too close to other ones |
Found a working colour - |
@ThomasTJdev it's not for the code, it's for the color in language % of repos and in short view for repos (where there's a color near the language name) And both |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for your pull request and for taking the time to check with the community!
I'm going to need to revert this as it seems the colour proximity test didn't pick up a problem, but it is now on master:
We're going to need tweaking to resolve this. |
I've now worked out why the passed before: Dafny got the |
This PR changes Nim language's colour to better match the logo - from
#37775b
to#ffdf00
Description
For a long time I wondered why Nim has the green colour on GitHub, and today I decided to dig deeper in it. Turns out Nim was made green by the initial commit which added colours - c3d6fc5 and was never changed after that.
With this PR I want to make the colour more consistent with the logo and branding (most of it is the goldish yellow)
Checklist: