Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Altium Designer Files #4538

Merged
merged 2 commits into from
May 29, 2019
Merged

Conversation

sciguy14
Copy link
Contributor

This pull request adds support for Altium Designer files. Altium Software is used to design printed rigid and flexible circuit boards. More info about Altium: https://www.altium.com/altium-designer/

Description

Altium uses many file types, but I've included the ones that can be represented in an ASCII format in this pull request. Many others are binary files only.

Checklist:

  • I am adding a new language.
    • The extension of the new language is used in hundreds of repositories on GitHub.com.
    • I have included a real-world usage sample for all extensions added in this PR:
      • Sample source(s): I made the simplest possible PCB design with Altium Designer 19 and am providing the resulting sample files in this PR.
      • Sample license(s): I hereby release these sample files under a permissive license.

Question: It wasn't clear to me from the Contributing Guidelines - How does color selection work? I added a color to the languages.yml file, but running bundle exec rake test complained when a color was specified. The color used on all of Altium's branding is: #a5915f

Copy link
Contributor

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request!

One quick thing to check below.

lib/linguist/languages.yml Outdated Show resolved Hide resolved
Altium files can't have shebangs
Copy link
Contributor

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@lildude lildude merged commit 4e8c364 into github-linguist:master May 29, 2019
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants