-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for TI Program #3258
Conversation
Does anybody know why the Travis CI build is failing? |
Linguist doesn't process binary files, only plain-text formats. Those binaries should be removed, and they're also what're causing the build to fail. |
Okay, thanks! |
Alphabetized extensions and added a language_id.
Good grief, I wrote that comment without even noticing your question OR your response... talk about timing. Now, concerning the in-the-wild usage... I only found 52 results for the You should also put |
Haha, I thought so. Your response appeared almost immediately after I clicked "Comment". As for the in-the-wild usage, that's a bit messy... These programs are written on the TI-84 graphing calculator rather than a regular computer. But the TI-84 stores them as binary files rather than plain text, so when you go to read them on the computer you just get gibberish. You can open them up and read/edit the source on the calculator itself but if you send the programs to a computer or put them on GitHub you can't read the source. To fix this, some people use a tool like this one to convert the binary file to plain text so that it's readable on GitHub. They then upload the plain text to their repository alongside their regular program. There's no standardized extensions for the text files, so My main concern though is just that |
Ah yes, that'd probably be best. Definitely remove the However, this is the part that concerns me:
This would imply that Is there anything we can use to search for TI Code programs stored in |
|
Ah, right. In that case, let's keep it at the Regarding the name... I know you said "TI PGRM" is an umbrella term, but I couldn't find much use of the term when googling it. I noticed you more recently renamed it to "TI Code"... is there anything more definitive, or is that the closest we have? TI-BASIC seems to be the most commonly-used name for it, though I know you said there were other (unrelated) languages that're using the same file extension... how unrelated are they, exactly? |
What about the name Texas Instruments Program...? If there's no name for these languages (which is probably the case), I'd say that's more descriptive than "TI Code" (which sounds pretty normative). We can always add "TI-BASIC" as an alias to help with people who want to search for programs in this language. |
That's what I was worried about too with the I also like your thought process for the name! Texas Instruments Program is more descriptive than just TI Code, and since there's not an official term it's best to be descriptive. What if we abbreviated it so that it's TI Program? My reason for this is because when you're looking on someone's repository page, Texas Instruments Program is too long and get's wrapped to three lines. |
It wouldn't be the first language to do something like that, don't worry. It is long, but it also spares a reader from having to google "TI" to find out what it stands for. I feel that's a point open to discussion, though. @pchaigno, @arfon... what're your thoughts? :) |
I'd rather have nothing than have Texas Instruments Program, to be honest. I realize that sounds demanding, its just that it looks too cluttered with three lines of text. After all, more common languages such as HTML and CSS are abbreviated, and "TI Program" still brings up relevant results on Google. |
Don't get too attached to what you see on GitHub. Sporadic layout changes happen all the time. Sure, it might look like this today: ... until you wake up one day and find it looking like this: The take-home point is that language names have more permanency on GitHub than its layout does. It's not right to justify a choice of name based on how it might be presented at any one point in time. I feel I should stress I'm actually not GitHub staff, just a regular contributor to this repository. The actual maintainer is very busy, so contributors go out of their way to help answer questions in advance. |
Absolutely. I don't think we should make a decision on the Linguist language name based upon GitHub's layout. @scottmangiapane - I think we should either go with |
@arfon What if we compromised and did |
I can only find 133 results on Google for Some of them aren't even relevant. |
"Texas Instruments Program" is actually worse, there are more results sure but literally all of the results are off topic (usually about something called a "Texas Instruments Program Recorder"). And |
Erh, googling Texas Instruments Program seems to yield pretty relevant results. Am I missing something here? This would all be a lot easier if Texas Instruments bothered to give their calculator-languages a proper name. ;p |
What's the issue with the current TI Program? That's how I used to call it and it yields relevant results on Google... |
Potentially none |
Thank you! I think the main reason @Alhadis is opposed to it because it's not as descriptive as If you approve @arfon, the code is all ready to be merged :) |
OK thanks @scottmangiapane. Can you just confirm the origin of the sample files included in this PR? They need to have a permissive license (MIT, BST, Apache 2.0 etc.) to be acceptable to Linguist. |
Sure! They're all my own code, and they're licensed under the MIT license. |
⚡️ thanks for this @scottmangiapane. This will be live in the next release of Linguist (likely next week sometime). @Alhadis - thanks for helping us explore all possible combinations of names here 😁 |
Hey @arfon / @Alhadis, how come my repositories still aren't being recognized? Did I do something wrong in my pull request or is the new release just taking a while to circulate? |
Ah, that'll probably be because the results are still cached from before the release was cut. =) Just push some changes to your repos, and it should bust the cache and force a reindexing. |
No luck :/ I tried updating a file, removing everything, restoring everything, adding a new file, and deleting the new file. I'm looking through the contribution guidelines though and I might've found it. The readme says that I have to run the 'set-language-ids script' to update the language ID, but I don't think it said that a couple weeks ago so I had just added one manually instead of running the script. Maybe that broke it? |
I've run Linguist locally on your repo, and it's because the Try changing the file extension of the text file to |
You're right, that fixed it! Thanks :) |
"TI Program" is an umbrella name for programs/apps written for the Texas Instruments 83+/84 graphing calculator, which has multiple sublanguages such as TI-BASIC, Axe, and Assembly, all possessing the same file extension. This pull request enables recognition of these previously unknown programs.
Example Programs