Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Skript language #6559

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Skript language #6559

wants to merge 1 commit into from

Conversation

patHyatt
Copy link

@patHyatt patHyatt commented Sep 24, 2023 •
edited by lildude
Loading

Adds support for Skript language

Resolves #6554

Checklist:

@patHyatt patHyatt requested a review from a team as a code owner September 24, 2023 12:17
@lildude lildude changed the title Add support for Skript language. Resolves #6554 Add Skript language Sep 25, 2023
lildude
lildude requested changes Sep 25, 2023
View reviewed changes
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a quick look but usage isn't quite there yet.

The bigger issue is there are way more .sk files that are not Skript than are and these will all be identified as Skript as soon as as this PR is merged. In order to prevent this, this PR will need to add at least another language that uses this extension, and a heuristic to distinguish the languages.

@lildude
Copy link
Member

lildude commented Sep 25, 2023

I've also just spotted this in the grammar readme:

NOTE: This is in development and not in a usable state.

We probably shouldn't be using this until such time as it is deemed usable… maybe it will be when the popularity requirements are met 🤷‍♂️

@patHyatt
Copy link
Author

@lildude Thanks. I kind of just ran with one of the good first issue labels.

In terms of proceeding, it sounds like we're more in the negative here.

With that in mind, the PR needs the following to be ready

  • - ensure this meets the popularity requirements, or grammar is more stable
  • - languages.yml -> color should be prefixed with # and surrounded with quotes
  • - add another '.sk' extension language skip, (skiplang.com), or skew (http://skew-lang.org/) , with heuristic to differentiate

@lildude lildude linked an issue May 28, 2024 that may be closed by this pull request
Add Skript #6857
Open
@lildude lildude mentioned this pull request Jul 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lildude lildude lildude requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Pending Popularity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Skript
2 participants
@patHyatt @lildude