Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prettier and eslint config for the project #7

Open
YugandharrPatil opened this issue Dec 22, 2023 · 5 comments
Open

prettier and eslint config for the project #7

YugandharrPatil opened this issue Dec 22, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@YugandharrPatil
Copy link
Contributor

I think adding a prettier and eslint config for the project would be ideal since varying configs of users can make it difficult for changes to be analyzed in PRs.

@gitdagray
Copy link
Owner

This is a good idea and one I'd like to prioritize so all the PRs aren't formatted differently.

@gitdagray
Copy link
Owner

Prettier config now added - see dev dependencies in package.json. Guide for this update here: https://gist.github.com/siakaramalegos/4a5cdab1f44ffb217a48d5260043f8ae

eslint config still needed - leaving this issue open.

@YugandharrPatil
Copy link
Contributor Author

YugandharrPatil commented Dec 22, 2023

how about we go with the infamous airbnb config? Here's the style guide: https://github.com/airbnb/javascript

@gitdagray
Copy link
Owner

how about we go with the infamous airbnb config? Here's the style guide: https://github.com/airbnb/javascript

Yes, I've looked at that in the past. Please do. 😀

@YugandharrPatil
Copy link
Contributor Author

How about we populate the prettier config? Because it'll keep giving errors until we populate it with something. Safe to close the issue after its addition I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants