Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dataset selection #1

Open
gflegar opened this issue Nov 21, 2018 · 0 comments
Open

Improve dataset selection #1

gflegar opened this issue Nov 21, 2018 · 0 comments
Labels
Enhancement An improvement of an existing feature. Help wanted Need ideas on how to solve this.

Comments

@gflegar
Copy link
Member

gflegar commented Nov 21, 2018

Currently, the dataset selection dropdown menu suffers from performance issues. This is because we have a large number of files (several thousand), and another entry (a <mat-option> component, containing a checkbox, a <span> with some text, and an additional <div>) has to be created for each file.

Additionally, it is very difficult to select a large number of files, since the user has to manually click on each one. As a workaround, we currently include a "summary" file in the Ginkgo dataset which contains the most relevant information from each of the individual files. However, this causes its own set of performance issues, since loading and processing the file is computationally demanding (for a web-based application).

Another issue is that it is impossible to explicitly link a plotting script to a set of data files it can use. Thus, loading any of the example scripts requires the user to know which of the datasets should be loaded for the script to work.

A possible solution

One option would be to replace the dropdown menu with a JSONata script (editable by the user) which will be used to load the files. The standard JSONata language can be enhanced with an an additional function that loads the data by using JSONata's registerFunction feature.
The script would get a list of all available datasets as input (contained in the dataset repository's list.json file) and produce a JSON object with all the datasets loaded. This object would then be passed on to the second script that plots the data. One plotting example would then contain two scripts: the data selection script, and the plotting script.

Alternatively, both scripts could be combined into a single script, though I'm not sure this is a better approach.

@gflegar gflegar added Enhancement An improvement of an existing feature. Help wanted Need ideas on how to solve this. labels Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement An improvement of an existing feature. Help wanted Need ideas on how to solve this.
Projects
None yet
Development

No branches or pull requests

1 participant