-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MM-Format IO Checking #1627
Comments
Actually, this is already checked. Consider this file:
Then reading and writing it again one would expect (without deeper knowledge of the MM standard) the matrix entries in a single list using column major format:
But instead one gets
|
This PR will discard any character in a line of a MM-format file after the values have been read in. This addresses #1627, using multiple columns within the MM-file will now lead to an exception. However, the exception is thrown by the `read_entry` function and thus the exception message is not very helpful. Related PR: #1628
Reading an MM-file doesn't check the file itself for consistency. For example, if the MM file defines a
6x4
matrix, but less then 24 lines after the size definition contain values, not all values of the created matrix/vector will be filled.IMO there should be a simple test that after a definition of a
MxN
dense matrix, exactlyM * N
lines should contain a value.This checking would not apply to the coordinate format, as missing values will be assumed to be zero anyway.
The text was updated successfully, but these errors were encountered: