-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default HIP_PATH does not work with ROCm >= 6.0 #1624
Comments
Actually, this problem spans to even the other HIP-related variables handled in You can reproduce this very easily using the ROCm dev images with Docker or Podman (note that you don't need any GPU to just build Ginkgo):
The last command will give the following error:
To make it work, the following exports are needed:
It would be nice to fix this in Ginkgo to make all the exports unnecessary 😉 |
Hi, I also recently ran into this issue. I think the definition of Regarding the libraries I could workaround all these paths by adding the rocm path to |
I agree with @tpadioleau that we should not set these paths and instead rely on |
Bumping issue from #1529 (comment):
hip_path.cmake
still defaults to/opt/rocm/hip
forHIP_PATH
which does not work with ROCm 6.0:ginkgo/cmake/hip_path.cmake
Line 3 in a8a407f
Furthermore,
hip.cmake
has a code path where$ENV{HIP_PATH}/..
is used for `ROCM_PATH:ginkgo/cmake/hip.cmake
Line 20 in a8a407f
It would be nice if Ginkgo could auto-detect ROCm version and use the correct paths for 6.0 by default 😉
The text was updated successfully, but these errors were encountered: