Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log create(...) functions #1237

Open
upsj opened this issue Dec 12, 2022 · 0 comments
Open

Log create(...) functions #1237

upsj opened this issue Dec 12, 2022 · 0 comments
Labels
is:todo This issue describes a concrete task to be done

Comments

@upsj
Copy link
Member

upsj commented Dec 12, 2022

Logger has a polymorphic_object_create_started/completed event, but it only works based on PolymorphicObject::create_default, not any other functions like the one provided by EnableCreateMethod. To change this, we could add another overload to the event that only gets passed the executor in _started and only the created object in _completed and gets called conditionally (if the first parameter is an executor) in EnableCreateMethod::create and manually in all the create_const functions.

@upsj upsj added the is:todo This issue describes a concrete task to be done label Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is:todo This issue describes a concrete task to be done
Projects
None yet
Development

No branches or pull requests

1 participant