Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigDecimal.new is deprecated #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

hazi
Copy link

@hazi hazi commented Feb 1, 2019

A warning is displayed when running with ruby ​​2.6
warning: BigDecimal.new is deprecated; use BigDecimal() method instead.

A warning is displayed when running with ruby ​​2.6
`warning: BigDecimal.new is deprecated; use BigDecimal() method instead.`
@emptyflask
Copy link

This is a really minor change, but fixes an annoying deprecation warning and works with all currently supported versions of ruby. Could we get this merged soon?

@hazi
Copy link
Author

hazi commented Feb 19, 2019

My current Gemfile

git_source(:github) { |repo_name| "https://github.com/#{repo_name}.git" }

# gem 'ginjo-rfm' # FileMaker API
gem 'ginjo-rfm', github: 'hazi/rfm', branch: 'fix_big_decimal'

@ginjo
Copy link
Owner

ginjo commented Feb 21, 2019

Thanks @hazi and @emptyflask , I'll review and merge this in soon as I get a chance.

@robinboening
Copy link

robinboening commented May 21, 2021

I am using Ruby 2.7 and it now throws an error. I am now running on my own fork until this is merged.

Friendly reminder to review & merge :)

@emptyflask
Copy link

Ping

@bentron2000
Copy link

+1 please please please merge 🤞🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants