Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if change of cgroup driver is ok #133

Closed
puja108 opened this issue May 26, 2017 · 3 comments
Closed

Check if change of cgroup driver is ok #133

puja108 opened this issue May 26, 2017 · 3 comments

Comments

@puja108
Copy link
Member

puja108 commented May 26, 2017

Because of kubernetes/kubernetes#43805 there's some incompatibility in cgroup drivers moving kubelet to k8s 1.6+

We had
native.cgroupdriver=systemd
and I tried starting kubelet with --cgroup-driver=systemd but that didn't work.

I now changed our docker config to native.cgroupdriver=cgroupfs. CoreOS themselves are now also going with the Docker default of cgroupfs (coreos/bugs#1435) so I think this is secure.

Still we want to re-check if this is actually the right decision as most of us don't really understand the implications of it.

@teemow WDYT?

@nhlfr nhlfr assigned nhlfr and unassigned nhlfr Jun 7, 2017
@teemow
Copy link
Member

teemow commented Jun 19, 2017

@puja108 within the old platform we ran into some issues with systemd units and docker and the systemd cgroup driver fixed that for us. but if now docker is the way to go i am fine. upgrade to cgroup v2 will be fun :D

@teemow
Copy link
Member

teemow commented Jun 19, 2017

oh. can this be closed since we are already on 1.6?

@puja108
Copy link
Member Author

puja108 commented Jun 19, 2017

yes, this issue was mainly to get your input on the issue, so lets close and keep an eye on it if we run into any issues

@puja108 puja108 closed this as completed Jun 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants