-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Use only selected features" un-check not working #270
Comments
confirmed, thanks for reporting. For the moment you have to clean the plot and recreate it from scratch |
This bug is related to the signal The problem is that when the layer changes, or the "Use only selected features" checkbox is unchecked, the signal is still connected. To resolve this, some solutions :
IMHO, it's a bad idea to call |
@jmonticolo thanks for the detailed report and for all the ideas. If you cannot provide a PR then I'll try to work on this issue in the next days |
I can't provide a PR for the moment because I don't know where to go for keep it simple and complete. Do you think to store a reference of rebuilt methods in a layer property when connected like : self.source_layer.data_plotly_rebuilts = []
self.source_layer.data_plotly_rebuilts.append(self.rebuild) is a good idea ? and you can disconnect all rebuild methods if the layer has |
After checking "Use only selected features" in Plot parameters, then unchecking it, after selecting features in plot, other features are kicked out
Steps to reproduce the behavior:
--The plot is generated for all the features
step 3
![](https://user-images.githubusercontent.com/57714410/138555802-72f91ea0-010c-49ff-aee6-b71708146ffe.png)
step 5
![](https://user-images.githubusercontent.com/57714410/138556056-8c6d8629-4ab4-4e58-9316-54d8a0e6b8ac.png)
step 6 this is not zoom, this is whole graph
![](https://user-images.githubusercontent.com/57714410/138556093-e8ffdbf3-50cf-4c02-8c32-c48515a06204.png)
The text was updated successfully, but these errors were encountered: