Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain behavior if the toc is not visible #8

Closed
egeloen opened this issue Dec 6, 2012 · 4 comments
Closed

Maintain behavior if the toc is not visible #8

egeloen opened this issue Dec 6, 2012 · 4 comments
Assignees
Labels

Comments

@egeloen
Copy link

egeloen commented Dec 6, 2012

Hey!

I just updated the theme of a project which uses your lib & it seems the nested toc elements are not hidden properly if the toc is not visible.

My theme hides by default the toc & allows to show it by clicking on a button.

I have created a jsbin to reproduce the issue.

@ghost ghost assigned gfranko Dec 6, 2012
@gfranko
Copy link
Owner

gfranko commented Dec 6, 2012

This is an interesting use case. Do you prefer for the TOC to open the nested item(s) for the current window scrollTop or to open as if it hasn't been interacted with yet, which means no nested items will be visible immediately upon making the TOC visible?

@egeloen
Copy link
Author

egeloen commented Dec 6, 2012

IMO, the TOC should be focus on the element for the current window scrollTop regardless of the level in the TOC. I use tocify to enhance the navigation of end users, so, pointing the current element seems to be the right behavior.

@gfranko gfranko closed this as completed in c06649b Dec 7, 2012
@gfranko
Copy link
Owner

gfranko commented Dec 7, 2012

I just updated the Tocify code, so if you could grab the latest copy you should not see this issue anymore. Let me know if you need anything else!

@egeloen
Copy link
Author

egeloen commented Dec 8, 2012

👍 All works fine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants