only register scroll event handler if necessary (expensive in IE) #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
gfranko
added a commit
that referenced
this pull request
Sep 26, 2013
only register scroll event handler if necessary (expensive in IE)
|
Thanks for the PR! I wonder if I should also implement a short (100-200 ms) debounce. |
gfranko
added a commit
that referenced
this pull request
Sep 26, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the scroll event handler is always attached, even with the scroll-detection related features disabled (
extendPage: false, scrollHistory:false, showAndHideOnScroll: false, highlightOnScroll: false), there is a notable lag in IE due to performance issues with jQuery'sscrollTop()(http://stackoverflow.com/a/5001300).This code change simply wraps the registration of the event handler in a check so that it is only registered if one of the relevant options is enabled to avoid wasting resources in a handler that ends up doing no work.