-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show file sizes on custom build page using GitHub API #106
Comments
Great idea! I am using my other project, DownloadBuilder.js, for the custom build. All it is doing is pulling each minified file from Github and concatenating the files. Here is where I am making the jsonp request to Github within Downloadbuilder.js, so you could potentially save that data from the response, and pass it back to the user here and here. Let me know if that does not make sense. |
Ah, cool, that makes sense. I'll probably try to take a look at it in the next week or so. |
Or if you want to present the file size to a user before he or she downloads the files, then you will have to make separate Github requests. We can figure it out. Once SelectBoxIt v3.0 is done, then we can look at refactoring the custom build process. |
I didn't get around to adding this in the current release, so I'm going to close this issue. If you are interested in working on it in the future I will definitely reopen it. |
Sounds good. I've been slammed with deliverables lately, sorry. |
I was actually looking at the custom build page, if you don't already have this on track, I may look into adding the file sizes for each option (using the GitHub API to grab actual file sizes) and a running total size for the options selected. Shouldn't be super hard to do and would be valuable for the end user I think, as they get immediate feedback on whether it is worth removing an option or not.
The text was updated successfully, but these errors were encountered: