Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate PDB function entries #808

Open
Swatinem opened this issue Aug 31, 2023 · 0 comments
Open

Deduplicate PDB function entries #808

Swatinem opened this issue Aug 31, 2023 · 0 comments

Comments

@Swatinem
Copy link
Member

We have seen cases in which a PDB contains conflicting / duplicated debug info for the same "physical" addr range.
The assumption is that a linker might do link time identical code folding (ICF), leaving behind the separate debug info for the code that was merged.

This theory was supported by a customer who has confirmed the conflicting functions contain the same (copy-pasted?) code.

We have similar deduplication code already for DWARF, and can implement that for PDB as well.

addr2line-pdb is also picking the first matching debug info entry, whereas we are currently picking the last one. But that is just an implementation detail and very much depends on the order in which the linker emits debug info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant