-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk-crashes): Set SDK version as release #52501
Conversation
Set SDK version as release to understand on which SDK versions the SDK crashes occur.
sdk_version = get_path(sdk_crash_event_data, "sdk", "version") | ||
set_path(sdk_crash_event_data, "release", value=sdk_version) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this overwrite the release
the SDK sends? How does this code interact with users manually setting the release in their SDK initialization?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The allowlist of the event stripper doesn't include the release, as the release stems from the organization sending the event, which would basically be their app release. So we don't overwrite it. Instead, we set it so we can investigate which of our SDK versions is causing the crash in Sentry.
sentry/src/sentry/utils/sdk_crashes/event_stripper.py
Lines 27 to 93 in 47e7d7a
EVENT_DATA_ALLOWLIST = { | |
"type": Allow.SIMPLE_TYPE, | |
"datetime": Allow.SIMPLE_TYPE, | |
"timestamp": Allow.SIMPLE_TYPE, | |
"platform": Allow.SIMPLE_TYPE, | |
"sdk": { | |
"name": Allow.SIMPLE_TYPE, | |
"version": Allow.SIMPLE_TYPE, | |
"integrations": Allow.NEVER.with_explanation("Users can add their own integrations."), | |
}, | |
"exception": { | |
"values": { | |
"stacktrace": { | |
"frames": { | |
"filename": Allow.NEVER.with_explanation( | |
"The filename path could contain the app name." | |
), | |
"function": Allow.SIMPLE_TYPE, | |
"raw_function": Allow.SIMPLE_TYPE, | |
"module": Allow.SIMPLE_TYPE, | |
"abs_path": Allow.SIMPLE_TYPE, | |
"in_app": Allow.SIMPLE_TYPE, | |
"instruction_addr": Allow.SIMPLE_TYPE, | |
"addr_mode": Allow.SIMPLE_TYPE, | |
"symbol": Allow.SIMPLE_TYPE, | |
"symbol_addr": Allow.SIMPLE_TYPE, | |
"image_addr": Allow.SIMPLE_TYPE, | |
"package": Allow.SIMPLE_TYPE, | |
"platform": Allow.SIMPLE_TYPE, | |
} | |
}, | |
"value": Allow.NEVER.with_explanation("The exception value could contain PII."), | |
"type": Allow.SIMPLE_TYPE, | |
"mechanism": { | |
"handled": Allow.SIMPLE_TYPE, | |
"type": Allow.SIMPLE_TYPE, | |
"meta": { | |
"signal": { | |
"number": Allow.SIMPLE_TYPE, | |
"code": Allow.SIMPLE_TYPE, | |
"name": Allow.SIMPLE_TYPE, | |
"code_name": Allow.SIMPLE_TYPE, | |
}, | |
"mach_exception": { | |
"exception": Allow.SIMPLE_TYPE, | |
"code": Allow.SIMPLE_TYPE, | |
"subcode": Allow.SIMPLE_TYPE, | |
"name": Allow.SIMPLE_TYPE, | |
}, | |
}, | |
}, | |
} | |
}, | |
"contexts": { | |
"device": { | |
"family": Allow.SIMPLE_TYPE, | |
"model": Allow.SIMPLE_TYPE, | |
"arch": Allow.SIMPLE_TYPE, | |
"simulator": Allow.SIMPLE_TYPE, | |
}, | |
"os": { | |
"name": Allow.SIMPLE_TYPE, | |
"version": Allow.SIMPLE_TYPE, | |
"build": Allow.SIMPLE_TYPE, | |
}, | |
}, | |
} |
Set SDK version as release to understand on which SDK versions the SDK crashes occur.