feat(sdk-crash-detection): Set in app for SDK frames #52083
Conversation
Set in_app to true only for SDK frames and to false for all others. Closes #51024
github-actions
bot
added
the
Scope: Backend
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52083 +/- ##
==========================================
- Coverage 79.31% 79.31% -0.01%
==========================================
Files 4901 4901
Lines 205062 205066 +4
Branches 35054 35055 +1
==========================================
- Hits 162652 162647 -5
- Misses 37451 37457 +6
- Partials 4959 4962 +3
|
| cocoa_sdk_frame = stripped_frames[-1] | ||
| assert cocoa_sdk_frame == { | ||
| "function": "SentryCrashMonitor_CPPException.cpp", | ||
| "package": "/private/var/containers/Bundle/Application/59E988EF-46DB-4C75-8E08-10C27DC3E90E/iOS-Swift.app/Frameworks/Sentry.framework/Sentry", |
There was a problem hiding this comment.
What does the UUID(?) after /Application/ refer to? May this UUID become a flaky test?
There was a problem hiding this comment.
The UUID is generated from iOS. It's the sandbox for every iOS app, and every app has a different UUID / sandbox folder. I just copied the path from one of the installations of our Cocoa sample app.
There was a problem hiding this comment.
Why do you think the UUID could lead to a flaky test, @iker-barriocanal?
There was a problem hiding this comment.
All good in that case, I didn't know where the UUID was coming from.
There was a problem hiding this comment.
Thanks for asking 🙏, @iker-barriocanal.
Set in_app to true only for SDK frames and to false for all others.
Closes #51024