Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK Crash Detection: Define an allow list for stack traces #50916

Closed
Tracked by #44342
philipphofmann opened this issue Jun 14, 2023 · 0 comments · Fixed by #52082
Closed
Tracked by #44342

SDK Crash Detection: Define an allow list for stack traces #50916

philipphofmann opened this issue Jun 14, 2023 · 0 comments · Fixed by #52082
Assignees
@philipphofmann
Labels
Scope: Backend Automatically applied to PRs that change backend components

Comments

@philipphofmann
Copy link
Member

philipphofmann commented Jun 14, 2023 •
edited
Loading

Define an allow list for which frames the feature can keep cause the current logic doesn't guarantee accidentally collecting irrelevant frames from customers.

sentry/src/sentry/utils/sdk_crashes/event_stripper.py

Lines 122 to 132 in ea6b6dc

def _strip_frames(
frames: Sequence[Mapping[str, Any]], sdk_crash_detector: SDKCrashDetector
) -> Sequence[Mapping[str, Any]]:
"""
Only keep SDK frames or non in app frames.
"""
return [
frame
for frame in frames
if sdk_crash_detector.is_sdk_frame(frame) or frame.get("in_app", None) is False
]

We only keep SDK frames and system library frames, which we detect based on the code_file path as described here #51023.
@philipphofmann philipphofmann mentioned this issue Jun 14, 2023
Closed
@philipphofmann philipphofmann changed the title Define an allow list for stack traces SDK Crash Detection: Define an allow list for stack traces Jun 14, 2023
@philipphofmann philipphofmann self-assigned this Jun 14, 2023
@philipphofmann philipphofmann added the Scope: Backend Automatically applied to PRs that change backend components label Jun 14, 2023
philipphofmann added a commit that referenced this issue Jul 3, 2023
@philipphofmann
feat(sdk-crash-detection): Keep system lib frames
f52b8a1 
Only keep SDK frames and system library frames detected based
on the library path.

Closes #50916
@philipphofmann philipphofmann mentioned this issue Jul 3, 2023
Merged
philipphofmann added a commit that referenced this issue Jul 3, 2023
@philipphofmann
feat(sdk-crash-detection): Keep system lib frames (#52082)
a1c2d96 
Only keep SDK and system library frames detected based on the library
path.

Closes #50916
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@philipphofmann philipphofmann

Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
Mobile & Cross Platform SDK
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(sdk-crash-detection): Keep system lib frames getsentry/sentry
1 participant
@philipphofmann