Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(replay): Add further logging to network body parsing #9566

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Nov 15, 2023

We got somewhat closer to figuring out the problem there. Based on this comment: #9339 (comment)

The requests are now showing with the request body, but the response body is "undefined"

It seems that the problem is with parsing the response body for a XHR request. I added some more logging there, to be able to debug this further.

Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 65.47 KB (+0.08% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 55.63 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 30.98 KB (0%)
@sentry/browser - Webpack (gzipped) 21.3 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 61.95 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 29.1 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped) 21.24 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 195.42 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 88.32 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 63.3 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 31.81 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 65.82 KB (+0.09% 🔺)
@sentry/react - Webpack (gzipped) 21.34 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 82.54 KB (+0.07% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 48.13 KB (0%)
@sentry-internal/feedback - Webpack (gzipped) 16 KB (0%)

@mydea mydea merged commit 5698094 into develop Nov 16, 2023
81 checks passed
@mydea mydea deleted the fn/some-more-replay-network-logging branch November 16, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants