feat(nestjs): add SentryGlobalGenericFilter and allow specifying application ref in global filter
#13673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chargome
requested changes
Sep 19, 2024
|
I can't seem to properly run the tests locally. I followed the |
|
@Sjoertjuh thanks, I'll check that today and get back to you |
chargome
requested changes
Sep 23, 2024
There was a problem hiding this comment.
@Sjoertjuh looks good already, only the file formatting failed (yarn lint:prettier && yarn lint:biome)
chargome
approved these changes
Sep 24, 2024
Lms24
pushed a commit
that referenced
this pull request
Sep 24, 2024
This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution. See #13673 Co-authored-by: chargome <20254395+chargome@users.noreply.github.com>
alexandresoro
pushed a commit
to alexandresoro/ouca
that referenced
this pull request
Sep 25, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@sentry/node](https://github.com/getsentry/sentry-javascript/tree/master/packages/node) ([source](https://github.com/getsentry/sentry-javascript)) | dependencies | minor | [`8.31.0` -> `8.32.0`](https://renovatebot.com/diffs/npm/@sentry%2fnode/8.31.0/8.32.0) | | [@sentry/react](https://github.com/getsentry/sentry-javascript/tree/master/packages/react) ([source](https://github.com/getsentry/sentry-javascript)) | dependencies | minor | [`8.31.0` -> `8.32.0`](https://renovatebot.com/diffs/npm/@sentry%2freact/8.31.0/8.32.0) | --- ### Release Notes <details> <summary>getsentry/sentry-javascript (@​sentry/node)</summary> ### [`v8.32.0`](https://github.com/getsentry/sentry-javascript/releases/tag/8.32.0) [Compare Source](getsentry/sentry-javascript@8.31.0...8.32.0) ##### Important Changes - **ref(browser): Move navigation span descriptions into op ([#​13527](getsentry/sentry-javascript#13527 Moves the description of navigation related browser spans into the op, e.g. browser - cache -> browser.cache and sets the description to the performanceEntry objects' names (in this context it is the URL of the page). - **feat(node): Add amqplibIntegration ([#​13714](getsentry/sentry-javascript#13714 - **feat(nestjs): Add `SentryGlobalGenericFilter` and allow specifying application ref in global filter ([#​13673](getsentry/sentry-javascript#13673 Adds a `SentryGlobalGenericFilter` that filters both graphql and http exceptions depending on the context. - **feat: Set log level for Fetch/XHR breadcrumbs based on status code ([#​13711](getsentry/sentry-javascript#13711 Sets log levels in breadcrumbs for 5xx to error and 4xx to warning. ##### Other Changes - chore(nextjs): Bump rollup to 3.29.5 ([#​13761](getsentry/sentry-javascript#13761)) - fix(core): Remove `sampled` flag from dynamic sampling context in Tracing without Performance mode ([#​13753](getsentry/sentry-javascript#13753)) - fix(node): Ensure node-fetch does not emit spans without tracing ([#​13765](getsentry/sentry-javascript#13765)) - fix(nuxt): Use Nuxt error hooks instead of errorHandler to prevent 500 ([#​13748](getsentry/sentry-javascript#13748)) - fix(test): Unflake LCP test ([#​13741](getsentry/sentry-javascript#13741)) Work in this release was contributed by [@​Zen-cronic](https://github.com/Zen-cronic) and [@​Sjoertjuh](https://github.com/Sjoertjuh). Thank you for your contributions! ##### Bundle size 📦 | Path | Size | | ---------------------------------------------------------------- | ----------------- | | [@​sentry/browser](https://github.com/sentry/browser) | 22.63 KB | | [@​sentry/browser](https://github.com/sentry/browser) - with treeshaking flags | 21.42 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. Tracing) | 34.86 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. Tracing, Replay) | 71.36 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. Tracing, Replay) - with treeshaking flags | 61.79 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. Tracing, Replay with Canvas) | 75.71 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. Tracing, Replay, Feedback) | 88.48 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. Tracing, Replay, Feedback, metrics) | 90.36 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. metrics) | 26.91 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. Feedback) | 39.77 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. sendFeedback) | 27.29 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. FeedbackAsync) | 32.08 KB | | [@​sentry/react](https://github.com/sentry/react) | 25.38 KB | | [@​sentry/react](https://github.com/sentry/react) (incl. Tracing) | 37.84 KB | | [@​sentry/vue](https://github.com/sentry/vue) | 26.8 KB | | [@​sentry/vue](https://github.com/sentry/vue) (incl. Tracing) | 36.75 KB | | [@​sentry/svelte](https://github.com/sentry/svelte) | 22.76 KB | | CDN Bundle | 23.94 KB | | CDN Bundle (incl. Tracing) | 36.63 KB | | CDN Bundle (incl. Tracing, Replay) | 71.13 KB | | CDN Bundle (incl. Tracing, Replay, Feedback) | 76.44 KB | | CDN Bundle - uncompressed | 70.14 KB | | CDN Bundle (incl. Tracing) - uncompressed | 108.6 KB | | CDN Bundle (incl. Tracing, Replay) - uncompressed | 220.48 KB | | CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed | 233.69 KB | | [@​sentry/nextjs](https://github.com/sentry/nextjs) (client) | 37.8 KB | | [@​sentry/sveltekit](https://github.com/sentry/sveltekit) (client) | 35.43 KB | | [@​sentry/node](https://github.com/sentry/node) | 124.92 KB | | [@​sentry/node](https://github.com/sentry/node) - without tracing | 93.57 KB | | [@​sentry/aws-serverless](https://github.com/sentry/aws-serverless) | 103.28 KB | </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC45NC4zIiwidXBkYXRlZEluVmVyIjoiMzguOTQuMyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIl19--> Reviewed-on: https://git.tristess.app/alexandresoro/ouca/pulls/161 Reviewed-by: Alexandre Soro <code@soro.dev> Co-authored-by: renovate <renovate@git.tristess.app> Co-committed-by: renovate <renovate@git.tristess.app>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, a hybrid nestjs application should create its own global filter, since there is no way to use both http and graphql exception filters from sentry. This adds a new filter that uses the correct filter based on the context.
The new filter should also be usable for http-only and graphql-only applications, so it could be possible to deprecate the other filters.
These changes also allow the application ref to be set in the
SentryGlobalFilter, which can be nice if the filter is registered withapp.useGlobalFilters()