Skip to content

Commit

Permalink
build: Bump node to 18.20.3 (#12271)
Browse files Browse the repository at this point in the history
I noticed that locally the node-integration-tests that check versions
fail, because in the SDK we use 18.18.0, we only check for "If
node.major >= 18", and then get an incorrect test because actually in
code we check the minor too.

Instead of adjust this, IMHO it's better to update this. This also never
failed on CI because there we do use latest 18 for the matrix tests...
  • Loading branch information
mydea authored May 29, 2024
1 parent bf0a138 commit 81e0fd1
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 13 deletions.
4 changes: 2 additions & 2 deletions .size-limit.js
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ module.exports = [
name: 'CDN Bundle (incl. Tracing, Replay)',
path: createCDNPath('bundle.tracing.replay.min.js'),
gzip: true,
limit: '70 KB',
limit: '72 KB',
},
{
name: 'CDN Bundle (incl. Tracing, Replay, Feedback)',
Expand All @@ -170,7 +170,7 @@ module.exports = [
path: createCDNPath('bundle.tracing.min.js'),
gzip: false,
brotli: false,
limit: '105 KB',
limit: '110 KB',
},
{
name: 'CDN Bundle (incl. Tracing, Replay) - uncompressed',
Expand Down
3 changes: 1 addition & 2 deletions dev-packages/e2e-tests/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,7 @@
"yaml": "2.2.2"
},
"volta": {
"node": "18.20.2",
"yarn": "1.22.22",
"extends": "../../package.json",
"pnpm": "8.15.8"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
"@playwright/test": "^1.27.1"
},
"volta": {
"extends": "../../package.json",
"node": "18.19.1"
"extends": "../../package.json"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
"@playwright/test": "^1.27.1"
},
"volta": {
"extends": "../../package.json",
"node": "18.19.1"
"extends": "../../package.json"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
"@playwright/test": "^1.27.1"
},
"volta": {
"extends": "../../package.json",
"node": "18.19.1"
"extends": "../../package.json"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
"@playwright/test": "^1.27.1"
},
"volta": {
"extends": "../../package.json",
"node": "18.19.1"
"extends": "../../package.json"
}
}
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"yalc:publish": "lerna run yalc:publish"
},
"volta": {
"node": "18.18.0",
"node": "18.20.3",
"yarn": "1.22.19"
},
"workspaces": [
Expand Down

0 comments on commit 81e0fd1

Please sign in to comment.