Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow closing of SDK #467

Merged
merged 4 commits into from
Apr 14, 2022
Merged

feat: Allow closing of SDK #467

merged 4 commits into from
Apr 14, 2022

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Apr 13, 2022 •
edited
Loading

Closes #465

  • Exports close and flush from @sentry/node for the main process
  • Exposes close and flush from the root export and errors if they're called from the renderer
  • When enabled === false, deletes minidump files rather than sending
  • Add a test for the above

@timfish timfish marked this pull request as ready for review April 14, 2022 11:26
@timfish timfish requested a review from AbhiPrasad April 14, 2022 13:22
@timfish timfish merged commit 3354749 into getsentry:master Apr 14, 2022
@timfish timfish deleted the feat/close-and-flush branch April 14, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sentry cannot be closed once init was called
2 participants
@timfish @AbhiPrasad