Fix exponential backoff delay overflowing the maximum delay in setTimeout, causing a high number of requests and errors #441
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
setTimeout
function has an interesting implementation detail where, if the delay is bigger than the biggest signed 32-bit integer, it will throw an error and run the callback after 1ms.The error looks something like this:
Since this error is also reported to Sentry by default, this causes a huge number of errors which can block the main thread.
My workaround for this is to limit the delay to 2,000,000,000 ms so it never overflows.