Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wait for the db init & upgrade #7167

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zachliu
Copy link
Contributor

@zachliu zachliu commented Sep 18, 2024

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • New Query Runner (Data Source)
  • New Alert Destination
  • Other

Description

The sleep is for #7166. Otherwise the docker compose run cypress yarn cypress db-seed finds the database not ready.

How is this tested?

  • Unit tests (pytest, jest)
  • E2E Tests (Cypress)
  • Manually
  • N/A

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.20%. Comparing base (a2611b8) to head (004cb6d).
Report is 22 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7167      +/-   ##
==========================================
+ Coverage   64.15%   64.20%   +0.05%     
==========================================
  Files         162      162              
  Lines       13295    13309      +14     
  Branches     1883     1886       +3     
==========================================
+ Hits         8529     8545      +16     
+ Misses       4432     4431       -1     
+ Partials      334      333       -1     

see 2 files with indirect coverage changes

@justinclift
Copy link
Member

k, I guess we can try this and see how it goes with #7166. I'm not personally a fan of using sleep statements, but we can figure out something better later on if it turns out to be needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants