Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Adding ability to fix table columns in place (#7019)" #7131

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

eradman
Copy link
Collaborator

@eradman eradman commented Aug 23, 2024

This reverts commit ebb0e2c.

What type of PR is this?

  • Revert

Description

For reasons that are unclear, ant is adding style="overflow: auto hidden;" when fixed columns are used. This disables virtical scrolling. Further homework is required.

How is this tested?

  • Manually

Related Tickets & Documents

#7127

@eradman eradman force-pushed the revert-fixed-column-feature branch from f7c13d6 to 7e7c386 Compare August 23, 2024 15:02
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.18%. Comparing base (a2611b8) to head (7e7c386).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7131      +/-   ##
==========================================
+ Coverage   64.15%   64.18%   +0.03%     
==========================================
  Files         162      162              
  Lines       13295    13302       +7     
  Branches     1883     1884       +1     
==========================================
+ Hits         8529     8538       +9     
+ Misses       4432     4431       -1     
+ Partials      334      333       -1     

see 1 file with indirect coverage changes

@eradman eradman mentioned this pull request Aug 23, 2024
2 tasks
Copy link
Member

@justinclift justinclift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets get it done. 😄

@justinclift justinclift merged commit 79a4c4c into getredash:master Aug 26, 2024
13 checks passed
@eradman eradman deleted the revert-fixed-column-feature branch September 16, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants