Conditionally render tooltip for Edit alert button #7054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
Currently, an empty tooltip appears when you hover over the "Edit" button on the alerts page and you have permissions to edit. This fix makes it so that the empty tooltip doesn't appear.
A tooltip displaying a message will still appear if you don't have permissions to edit the alert.
How is this tested?
Hovered over "Edit" button with permissions and hovered over "Edit" button without permissions.
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Old (with permissions):
New (with permissions):
Same before and after change (without permissions):