Fixed frontend deprecation warnings from moment.js #7013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eradman
requested changes
Jun 13, 2024
There was a problem hiding this comment.
For reference, here is the warning the frontend tests emit:
Deprecation warning: value provided is not in a recognized RFC2822 or ISO format. moment construction falls back to js Date(), which is not reliable across all browsers and versions.
Non RFC2822/ISO date formats are discouraged. Please refer to http://momentjs.com/guides/#/warnings/js-date/ for more info.
Arguments:
[0] _isAMomentObject: true, _isUTC: false, _useUTC: false, _l: undefined, _i: 2021-01-27T00:00:01.733983944+03:00 stderr
f: undefined, _strict: undefined, _locale: [object Object]
Error:
at Function.createFromInputFallback (/remote/bhyve1/ci/eradman/redash/node_modules/moment/moment.js:324:25)
at configFromString (/remote/bhyve1/ci/eradman/redash/node_modules/moment/moment.js:2550:19)
at configFromInput (/remote/bhyve1/ci/eradman/redash/node_modules/moment/moment.js:2993:13)
at prepareConfig (/remote/bhyve1/ci/eradman/redash/node_modules/moment/moment.js:2976:13)
at createFromConfig (/remote/bhyve1/ci/eradman/redash/node_modules/moment/moment.js:2943:44)
at createLocalOrUTC (/remote/bhyve1/ci/eradman/redash/node_modules/moment/moment.js:3037:16)
at createLocal (/remote/bhyve1/ci/eradman/redash/node_modules/moment/moment.js:3041:16)
at hooks (/remote/bhyve1/ci/eradman/redash/node_modules/moment/moment.js:16:29)
at isDateTime (/remote/bhyve1/ci/eradman/redash/client/app/services/query-result.js:117:31)
at /remote/bhyve1/ci/eradman/redash/client/app/services/query-result.test.js:15:22
at Object.<anonymous> (/remote/bhyve1/ci/eradman/redash/node_modules/jest-each/build/bind.js:76:13)
at Object.asyncJestTest (/remote/bhyve1/ci/eradman/redash/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:102:37)
at /remote/bhyve1/ci/eradman/redash/node_modules/jest-jasmine2/build/queueRunner.js:43:12
at new Promise (<anonymous>)
at mapper (/remote/bhyve1/ci/eradman/redash/node_modules/jest-jasmine2/build/queueRunner.js:26:19)
at /remote/bhyve1/ci/eradman/redash/node_modules/jest-jasmine2/build/queueRunner.js:73:41
ezraodio1
force-pushed
the
fix-frontend-deprecation-warnings
branch
from
c0a9372
to
3528232
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
eradman
changed the title
|
This change solves the deprecation warnings in the browser console as well. @ezraodio1 did some more manual testing and pointed out that the tests cover a wide range of date inputs. This seems good to me, but we'll wait until the 2024-07 snapshot before merging |
|
Awesome, this'll be a welcome fix. 😄 |
eradman
approved these changes
Jul 8, 2024
Created Moment in ISO 8601 format instead of using the default Date() constructor.
eradman
force-pushed
the
fix-frontend-deprecation-warnings
branch
from
3528232
to
32c8624
Compare
|
Oops, I thought we'd merged this already. 🤦 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
Created Moment in ISO 8601 format instead of using the default Date() constructor.
How is this tested?