-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
query_runner -> query_results: improve logging, handle unhandled data types #6905
Open
vtatarin
wants to merge
24
commits into
getredash:master
Choose a base branch
from
vtatarin:fix-query-runner
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+63
−1
Open
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
aa7b93c
query_runner: add debug log
vtatarin fb4163c
query_runner: add debug log
vtatarin 4e7e468
handle datetime.time
vtatarin 11e4f0b
query_runner: add debug log
vtatarin 1f4853e
fmt
vtatarin e0ae3ba
add debug
vtatarin 051ed07
athena ds: fallback to default creds if RoleArn is not provided
vtatarin 71e433a
pull changes
vtatarin 17c00d6
pull changes
vtatarin 512bde7
Merge branch 'master' of github.com:vtatarin/redash into fix-query-ru…
vtatarin be111d3
expose error messae
vtatarin 26b5f7c
expose error messae
vtatarin 8d155bf
revert additional changes
vtatarin 374e6bf
revert additional changes
vtatarin 1a7f204
revert additional changes
vtatarin d22df7c
Update redash/query_runner/query_results.py
vtatarin 30776b3
review edits
vtatarin c9feda5
Merge branch 'getredash:master' into fix-query-runner
vtatarin a181ba9
add tests
vtatarin d3f8cad
add tests
vtatarin 0778b71
fmt
vtatarin a8023fb
fix
vtatarin 4e3cbdb
fix lint
vtatarin 5e69e3f
fix lint
vtatarin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty sure we don't want debugging statements being unconditionally run. At least with the change above it, it seems to be done conditionally there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@justinclift thank you for the reply! So there are 2 things:
logger
only logs (prints to stdout/stderr) messages, nothing is actually run/executed. The default log level is INFO, sologger.debug
is actually a condition which logs the data only at a more verbose levelThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping @justinclift
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vtatarin Sorry, but I'm short on time for the next few weeks.
Am getting some (Redash related) stuff deployed to a data centre, and that's taking the majority of my focus time. When that's done I'll be able to look at PRs properly. 😄