Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoformat hyperlinks in Slack alerts #6845

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

eradman
Copy link
Collaborator

@eradman eradman commented Apr 2, 2024

What type of PR is this?

  • Feature

Description

Format the Slack message using the "mrkdwn" type, which will make hyperlinks clickable.

How is this tested?

  • Unit tests (pytest, jest)
  • Manually

Created alert destination using webhook url, verified in Slack channel.

Related Tickets & Documents

#6821

Screenshot

slack-alert

Format the Slack message using the "mrkdwn" type, which will make
hyperlinks clickable.

New test for Slack destination.
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.50%. Comparing base (a607487) to head (623d5a2).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6845      +/-   ##
==========================================
+ Coverage   63.43%   63.50%   +0.06%     
==========================================
  Files         163      163              
  Lines       13206    13206              
  Branches     1824     1824              
==========================================
+ Hits         8377     8386       +9     
+ Misses       4531     4518      -13     
- Partials      298      302       +4     
Files Coverage Δ
redash/destinations/slack.py 70.96% <ø> (+29.03%) ⬆️

Copy link
Member

@justinclift justinclift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, looks good to me. 😄

@justinclift justinclift enabled auto-merge (squash) April 3, 2024 01:04
@justinclift justinclift merged commit 38a06c7 into getredash:master Apr 3, 2024
13 checks passed
@eradman eradman deleted the slack-alert branch April 12, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants