Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SSH deployment key to bump version and tag release candiate #6789

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

eradman
Copy link
Collaborator

@eradman eradman commented Feb 29, 2024

To allow this workflow to run even though normal contributors are required to create a pull request.

What type of PR is this?

  • Feature
  • Bug Fix

Description

Steps:

  1. Generate SSH key pair: ssh-keygen -t ed25519. No need for passphrases etc.
  2. Add public key (.pub one) as a deploy key at Your repo -> Settings -> Security -> Deploy keys, check "Allow write access".
  3. Add private key as a secret at Your repo -> Settings -> Security -> Secrets and variables -> Actions

Based on https://stackoverflow.com/a/76135647/1809872

How is this tested?

  • Manually

Related Tickets & Documents

#6416

To allow this workflow to run even though normal contributors
are required to create a pull request.

Steps:

1. Generate SSH key pair: ssh-keygen -t ed25519. No need for passphrases etc.
2. Add public key (.pub one) as a deploy key at Your repo -> Settings ->
   Security -> Deploy keys, check "Allow write access".
3. Add private key as a secret at Your repo -> Settings -> Security -> Secrets
   and variables -> Actions

https://stackoverflow.com/a/76135647/1809872
@eradman
Copy link
Collaborator Author

eradman commented Feb 29, 2024

@arikfr the owner of the repository needs to create the deployment key.

If this can be done before the end of the day we will be able to observe the success/failure of this action, which will run on March 1.

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.41%. Comparing base (81d22f1) to head (f7e249c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6789   +/-   ##
=======================================
  Coverage   63.41%   63.41%           
=======================================
  Files         162      162           
  Lines       13186    13186           
  Branches     1822     1822           
=======================================
  Hits         8362     8362           
  Misses       4527     4527           
  Partials      297      297           

@justinclift
Copy link
Member

@eradman I've just bumped up your permission for this repo to Admin level. I think that means you can add the deploy keys and adjust stuff as needed yourself now. 😄

@arikfr
Copy link
Member

arikfr commented Mar 1, 2024

Thanks, @justinclift ! @eradman let me know if you still need my assistance.

@eradman
Copy link
Collaborator Author

eradman commented Mar 1, 2024

Excellent! Thank you @arikfr @justinclift


Added the deployment key (id_ecdsa.pub):
action_deployment_pub


And the SSH private key (id_ecdsa)
action_push_key

@eradman eradman requested a review from justinclift March 1, 2024 14:05
Copy link
Member

@justinclift justinclift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems pretty straight forward. 😄

@justinclift justinclift merged commit 1200f98 into getredash:master Mar 1, 2024
15 checks passed
@justinclift
Copy link
Member

Good stuff @eradman, hopefully it all works properly from here on. 😄

@eradman eradman deleted the automatic-snapshot branch March 1, 2024 14:59
@eradman
Copy link
Collaborator Author

eradman commented Mar 1, 2024

+1 I think we finally got it right! We shall see

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants