Publish preview Docker image when release candidate is tagged #6787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Only respond to new tags ending with -dev * Use github account name to allow easier testing in a fork * Allow preview image to be referenced by a specific tag, or by latest tag redash/preview:24.02.0-dev redash/redash:preview
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6787 +/- ##
=======================================
Coverage 63.41% 63.41%
=======================================
Files 162 162
Lines 13186 13186
Branches 1822 1822
=======================================
Hits 8362 8362
Misses 4527 4527
Partials 297 297 |
AndrewChubatiuk
approved these changes
Feb 29, 2024
justinclift
previously approved these changes
Mar 1, 2024
justinclift
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
Every time a pull request is submitted a new docker image is uploaded. This should be fixed by only responding to changes that were merged. This proposal goes further and only publishes commits that were tagged.
redash/preview:24.02.0-dev
redash/redash:preview
How is this tested?
git tag 24.03.0-dev git push origin --tags 24.03.0-dev # wait for build docker pull eradman/preview:24.02.0-dev