Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RisingWave support #6776

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Add RisingWave support #6776

merged 1 commit into from
Mar 5, 2024

Conversation

stefannegele
Copy link
Contributor

@stefannegele stefannegele commented Feb 23, 2024

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • New Query Runner (Data Source)
  • New Alert Destination
  • Other

Description

RisingWave (1.6.0) is a PostgreSQL compatible streaming database. This PR basically uses the PostgreSQL query runner but changes the listing of tables in two ways:

  • not using incompatible postgres function (introduced after last redash release)
  • removing risingwave internal schemas from table listing

How is this tested?

  • Unit tests (pytest, jest)
  • E2E Tests (Cypress)
  • Manually
  • N/A

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 63.43%. Comparing base (11794b3) to head (b884e0d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6776      +/-   ##
==========================================
+ Coverage   63.41%   63.43%   +0.01%     
==========================================
  Files         162      163       +1     
  Lines       13186    13200      +14     
  Branches     1822     1822              
==========================================
+ Hits         8362     8373      +11     
- Misses       4527     4530       +3     
  Partials      297      297              
Files Coverage Δ
redash/settings/__init__.py 98.65% <ø> (ø)
redash/query_runner/risingwave.py 78.57% <78.57%> (ø)

@konnectr
Copy link
Collaborator

I believe that it is necessary to allocate RisingWave to a separate file

@gaecoli
Copy link
Member

gaecoli commented Feb 27, 2024

I believe that it is necessary to allocate RisingWave to a separate file

You are right!

@stefannegele
Copy link
Contributor Author

Hi, i moved the code to its own file. Sadly now the data source is not showing up in the UI anymore. What am I missing?

@konnectr
Copy link
Collaborator

konnectr commented Mar 2, 2024

You need to add settings https://github.com/getredash/redash/blob/master/redash/settings/__init__.py#L341 @stefannegele

@stefannegele
Copy link
Contributor Author

@konnectr thanks for the hint! I just applied it, then tested, squashed, and rebased to upstream. Let me know if you need anything else for this to get accepted :)

Copy link
Member

@gaecoli gaecoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gaecoli gaecoli merged commit 34723e2 into getredash:master Mar 5, 2024
13 checks passed
@gaecoli
Copy link
Member

gaecoli commented Mar 5, 2024

Thank you! @stefannegele

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants