-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query schedule may not always contain an "until" key #6771
Query schedule may not always contain an "until" key #6771
Conversation
35d31b7
to
aa0d3db
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6771 +/- ##
=======================================
Coverage 63.43% 63.43%
=======================================
Files 163 163
Lines 13200 13200
Branches 1822 1822
=======================================
Hits 8373 8373
Misses 4530 4530
Partials 297 297
|
I can't figure out how SELECT id,array_agg(keys) AS key
FROM queries, jsonb_object_keys(schedule::jsonb) keys
GROUP BY id ORDER BY id; |
I've not modified it manually, there was a new migration added: https://github.com/getredash/redash/blob/master/migrations/versions/640888ce445d_.py Which touches the column. Running your query:
Looking a bit closer I have several rows where the schedule is null:
Then picking out a few examples where until is null:
|
@justinclift would it be possible to get a review |
@guidopetri Do you have time to look at this? It seems super simple. 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This record is wrong
{"disabled": true}
But I can't figure out how this value was set. Seems like it must have been a failed migration. Approving since we're not making progress. After this query is updated I expect the schedule to be formatted with standard fields.
Thanks. Just merged it. 😄 |
What type of PR is this?
Description
Noticed this error occurring from redash in our Sentry:
How is this tested?
Sentry error stopped occurring
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)