removed PseudoJSON #6687
Merged
removed PseudoJSON #6687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewChubatiuk
force-pushed
the
removed-pseudojson
branch
from
7218a03
to
30fd644
Compare
eradman
requested changes
Jan 4, 2024
AndrewChubatiuk
force-pushed
the
removed-pseudojson
branch
2 times, most recently
from
b643c2f
to
f524ab3
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #6687 +/- ##
==========================================
+ Coverage 63.30% 63.38% +0.07%
==========================================
Files 162 162
Lines 13322 13165 -157
Branches 1820 1817 -3
==========================================
- Hits 8434 8344 -90
+ Misses 4599 4532 -67
Partials 289 289
|
AndrewChubatiuk
force-pushed
the
removed-pseudojson
branch
from
f524ab3
to
34e96d1
Compare
eradman
reviewed
Jan 9, 2024
AndrewChubatiuk
force-pushed
the
removed-pseudojson
branch
from
becbfa8
to
a0dd5f2
Compare
eradman
previously approved these changes
Jan 9, 2024
AndrewChubatiuk
force-pushed
the
removed-pseudojson
branch
from
a0dd5f2
to
e040508
Compare
eradman
approved these changes
Jan 11, 2024
|
@justinclift what do you think about waving the code coverage check? It would be very difficult to make this check pass with a change like this |
|
@eradman Yeah, the code coverage stuff is definitely a case of "don't worry about it in situations where it doesn't apply". 😄 |
10 tasks
|
It looks like using jsonb is having some unintended consequences for people with large data sets: #6706 (comment) We might need to revert this change. |
|
I beleive we can change @AndrewChubatiuk can you explore that solution? |
10 tasks
wlach
added a commit
to wlach/redash
that referenced
this pull request
Mar 28, 2024
Since getredash#6687, we don't serialize query results as JSON before returning them. This is fine, except for the query results data source which needs to pass the data directly to sqlite3, and doesn't know how to do that with the decimal types that are occasionally returned by (at least) the PostgreSQL query runner: https://www.psycopg.org/docs/faq.html#problems-with-type-conversions
10 tasks
justinclift
pushed a commit
that referenced
this pull request
Mar 29, 2024
Since #6687, we don't serialize query results as JSON before returning them. This is fine, except for the query results data source which needs to pass the data directly to sqlite3, and doesn't know how to do that with the decimal types that are occasionally returned by (at least) the PostgreSQL query runner: https://www.psycopg.org/docs/faq.html#problems-with-type-conversions
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Removed unneeded PseudoJSON and DBPersistence classes, migrated all json contained column's type to JSONB
How is this tested?