Fix date range selector does not show data of last day when user timezone is not UTC #653
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #594 and #617.
In following conditions, re:dash does not show the data of last day.
Like this:
I think this is caused
dateRange
is treated as local timezone, butpoint.x
is treated as UTC.Following screenshot is a result of
console.log(dateRange, point.x);
before https://github.com/EverythingMe/redash/blob/master/rd_ui/app/scripts/services/resources.js#L197This pull request fix this issue, but I'm not sure that this change is OK for timezone handling in re:dash.
@arikfr What do you think?