Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test class for JWT decoding #6314

Closed
wants to merge 1 commit into from
Closed

Conversation

eradman
Copy link
Collaborator

@eradman eradman commented Jul 28, 2023

What type of PR is this?

  • New unit tests

Description

After asserting current functionality, #6271 can be rebased and more easily evaluated.

@justinclift
Copy link
Member

Cool, this sounds like a good idea. 😄

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #6314 (f0fb4aa) into master (ea4ee7c) will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6314      +/-   ##
==========================================
+ Coverage   60.02%   60.10%   +0.08%     
==========================================
  Files         153      153              
  Lines       12494    12494              
  Branches     1692     1692              
==========================================
+ Hits         7500     7510      +10     
+ Misses       4781     4769      -12     
- Partials      213      215       +2     

see 1 file with indirect coverage changes

@eradman
Copy link
Collaborator Author

eradman commented Jul 28, 2023

CC @gaecoli

@justinclift justinclift added python Pull requests that update Python code Team Review Meets PR criteria, ready for full review labels Jul 28, 2023
Copy link
Member

@gaecoli gaecoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@justinclift
Copy link
Member

Looks like there's an conflict that needs fixing now?

@eradman
Copy link
Collaborator Author

eradman commented Jul 29, 2023

These tests were included in commit 0d69932, so I'll close this

@eradman eradman closed this Jul 29, 2023
@eradman eradman deleted the jwt-tests branch July 29, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests that update Python code Team Review Meets PR criteria, ready for full review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants