Feature: SQLite query runner #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| #from redash.query_runner import SUPPORTED_COLUMN_TYPES | ||
| from redash.query_runner import register | ||
| #from redash.query_runner import get_query_runner | ||
| #from redash.query_runner import import_query_runners |
There was a problem hiding this comment.
There is no point in keeping the commented out code... Let's remove it.
|
👍 looks good. I left two minor comments, let's sort those out and it can be merged. |
* Renamed "Database Name"/dbname to "Database Path"/dbpath
gissehel
force-pushed
the
sqlite_query_runner
branch
from
75fd089
to
e0a43a3
Compare
|
I corrected the points, The pr should work. |
|
Merged. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request add support for sqlite databases.
No type support because the nature of sqlite's types makes it difficult to infer the best type for a query result.
Should close #627