Make frontend build in Docker image optional

[arikfr]

What type of PR is this? (check all applicable)

• Other

Description

A different approach to making frontend build optional by using a build arg. While a bit more hacky, it's fully supported across different Docker versions and requires less changes.

Related Tickets & Documents

#4843, #4292

[arikfr]

Create dummy index.html and multi_org.html to make backend tests work.

[arikfr]

This isn't directly related, but used the opportunity to reduce even more duplicates.

[jezdez]

I think we had to fix the scheduler container for this anyway in our recent rebase: mozilla@ce5e606

[koooge]

I think it's a reasonable proposal. On another note, my works care about no-include requirements_dev.txt for production build. Is it possible in this PR?

By the way, Makefile is no longer update? #3038

[arikfr]

I think it's a reasonable proposal. On another note, my works care about no-include requirements_dev.txt for production build. Is it possible in this PR?

202e1da

By the way, Makefile is no longer update? #3038

I never used the Makefile... It's possible it's a bit out of sync.

[jezdez]

@arikfr While we're there, can we add a build argument to install an optional requirements file requirements_ext.txt if it exists? That would fix #2810.

[arikfr]

@arikfr While we're there, can we add a build argument to install an optional requirements file requirements_ext.txt if it exists? That would fix #2810.

No need for an arg, checking if file exists is enough. But I'm not sure about the usefulness of it. It saves the person to write a single command (RUN pip install...) and requires them to understand how the Dockerfile is built... Is it really worth the hassle?

[jezdez]

@arikfr While we're there, can we add a build argument to install an optional requirements file requirements_ext.txt if it exists? That would fix #2810.

No need for an arg, checking if file exists is enough. But I'm not sure about the usefulness of it. It saves the person to write a single command (RUN pip install...) and requires them to understand how the Dockerfile is built... Is it really worth the hassle?

It would be more than just RUN pip install.. since when inheriting from the Redash image you would have to also switch to the root user before to make sure the extensions are installed in the same location as the rest of the requirements. And then switch back to the redash user, which isn't ideal.

FROM redash/redash:preview

COPY requirements_ext.txt .
USER root
RUN pip install -r requirements_ext.txt
USER redash

But I now realize that there is the devil in the details, since I think ONBUILD is needed to make this work in a separate Dockerfile to make sure it happens at the correct build time. And ONBUILD isn't enough for frontend extensions to be installed before the webpack bundle is built. Hmm..

Maybe we should stop using webpack in favor of build-less packaging for the frontend assets like Snowpack?

[arikfr]

Maybe we should stop using webpack in favor of build-less packaging for the frontend assets like Snowpack?

Snowpack doesn't require build during development, but you still need to build for production/deployment.