Chart with a horizontal legend sometimes doesn't render properly #4683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Chart (with a lot of legend items - ?) on a small screens (when legend is below the plot) sometimes was rendered very small and didn't fit its container.
The bug was in the code that computes layout for horizontal legend -
updatePlot()result handler is called multiple times and on each turn mutateslayoutobject. It was using dimensions computed on previous turn and each time decreased plot height.Related Tickets & Documents
#4670 (comment)
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Before/After: