feat: Add ssl options for Cassandra data source #4665
Conversation
redash/query_runner/cass.py
Outdated
| @@ -22,6 +25,26 @@ def default(self, o): | |||
| return super(CassandraJSONEncoder, self).default(o) | |||
|
|
|||
|
|
|||
| def generate_cert_file(ssl_cert, host): | |||
| cert_dir = f"./tmp/cassandra_certificate/{host}" | |||
There was a problem hiding this comment.
I think it will be safer to use a random file name + clean up after use. Maybe use NamedTemporaryFile?
There was a problem hiding this comment.
ah cool, will use that.
|
hey @arikfr , did you get a chance to review the cahnges? |
|
Hey @arikfr ... just wanted to drop in and see if you had any timelines for this feature to be released? I have seen other PRs on this repo being rejected due to underlying refactor, do you think this PR might suffer the same fate? Also, Is there some documentation around how you publish the docker images, so I can try and have an interim docker Image until the next release? |
|
Thanks, @arihantsurana ! This is now merged. When master branch builds it builds two images:
This is the build for master with this PR merged: |
|
Awesome this is great!! |
|
@arihantsurana @arikfr |
IIRC I tested this with a .pem file. |
What type of PR is this? (check all applicable)
Description
Cassandra is regularly used in production with Encryption enabled, causing the Client to handle SSL options like protocol, and certificate. This PR adds the option to:
Related Tickets & Documents
https://discuss.redash.io/t/cassandra-does-not-support-ssl-with-certificates/5584
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Changes in the UI for Cassandra connection.
Before:
After:
