-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table visualization with column named "children" renders +/- buttons #4394
Conversation
@@ -65,6 +65,7 @@ export default function Renderer({ options, data, context }) { | |||
data-test="TableVisualization" | |||
columns={tableColumns} | |||
dataSource={preparedRows} | |||
childrenColumnName={null} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
childrenColumnName={null} | |
childrenColumnName={[]} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That worked after I update Antd, maybe they changed it to allow array recently?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
childrenName
prop is declared as optional/nullable, but later there are no any conditions - it's just used as is - e.g. item[this.props.childrenName]
- implicit cast to string. I'll try to find another solution.
What type of PR is this? (check all applicable)
Description
Related Tickets & Documents
Fixes #4393
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Before:
After: